From 318fc08d6f6ce8a5506671bbcae7e91118db8fbc Mon Sep 17 00:00:00 2001
From: Nikodemus Siivola <nikodemus@random-state.net>
Date: Tue, 15 Jan 2008 11:17:27 +0000
Subject: [PATCH] 1.0.3.34: better debug-name construction

 * Make *DEBUG-NAME-LEVEL* behave more like *PRINT-LEVEL*, and add
   *DEBUG-NAME-LENGTH*. Now, instead of the old

     (VARARG-ENTRY (LAMBDA (&OPTIONAL ("#<...>" . "#<...>") . "<...>")))

   we get

     (VARARG-ENTRY (LAMBDA (&OPTIONAL (FOO *BAR*) (QUUX *ZOT*)))

   which is a lot more useful.

 * Use slightly magical debug name markers that print as # and ...
   instead of strings when abbreviating names.
---
 src/compiler/early-c.lisp | 85 ++++++++++++++++++++++++++++++++++++-----------
 version.lisp-expr         |  2 +-
 2 files changed, 67 insertions(+), 20 deletions(-)

diff --git a/src/compiler/early-c.lisp b/src/compiler/early-c.lisp
index 978284fcc..ace5c682d 100644
--- a/src/compiler/early-c.lisp
+++ b/src/compiler/early-c.lisp
@@ -182,24 +182,71 @@ dynamic binding, even though the symbol name follows the usual naming~@
 convention (names like *FOO*) for special variables" symbol))
   (values))
 
-(defvar *debug-name-level* 6)
+(def!struct (debug-name-marker (:make-load-form-fun dump-debug-name-marker)
+                               (:print-function print-debug-name-marker)))
+
+(defvar *debug-name-level* 4)
+(defvar *debug-name-length* 12)
+(defvar *debug-name-punt*)
+(defvar *debug-name-sharp*)
+(defvar *debug-name-ellipsis*)
+
+(eval-when (:compile-toplevel :load-toplevel :execute)
+  (defun dump-debug-name-marker (marker &optional env)
+    (declare (ignore env))
+    (cond ((eq marker *debug-name-sharp*)
+           `(if (boundp '*debug-name-sharp*)
+                *debug-name-sharp*
+                (make-debug-name-marker)))
+          ((eq marker *debug-name-ellipsis*)
+           `(if (boundp '*debug-name-ellipsis*)
+                *debug-name-ellipsis*
+                (make-debug-name-marker)))
+          (t
+           (warn "Dumping unknown debug-name marker.")
+           '(make-debug-name-marker)))))
+
+(defun print-debug-name-marker (marker stream level)
+  (declare (ignore level))
+  (cond ((eq marker *debug-name-sharp*)
+         (write-char #\# stream))
+        ((eq marker *debug-name-ellipsis*)
+         (write-string "..." stream))
+        (t
+         (write-string "???" stream))))
+
+(setf *debug-name-sharp* (make-debug-name-marker)
+      *debug-name-ellipsis* (make-debug-name-marker))
 
 (defun debug-name (type thing)
-  (labels ((walk (x level)
-             (if (> *debug-name-level* (incf level))
-                 (typecase x
-                   (cons
-                    (cons (walk (car x) level) (walk (cdr x) level)))
-                   ((or symbol number string)
-                    x)
-                   (t
-                    (list 'of-type (type-of x))))
-                 "#<...>")))
-    ;; FIXME: It might be nice to put markers in the tree instead of
-    ;; this #<...> business, so that they would evantually be printed
-    ;; without the quotes.
-    (let ((name (list type (walk thing 0))))
-      (when (legal-fun-name-p name)
-        (bug "~S is a legal function name, and cannot be used as a ~
-              debug name." name))
-      name)))
+  (let ((*debug-name-punt* nil))
+    (labels ((walk (x)
+               (typecase x
+                 (cons
+                  (if (plusp *debug-name-level*)
+                      (let ((*debug-name-level* (1- *debug-name-level*)))
+                        (do ((tail (cdr x) (cdr tail))
+                             (name (cons (walk (car x)) nil)
+                                   (cons (walk (car tail)) name))
+                             (n (1- *debug-name-length*) (1- n)))
+                            ((or (not (consp tail))
+                                 (not (plusp n))
+                                 *debug-name-punt*)
+                             (cond (*debug-name-punt*
+                                    (setf *debug-name-punt* nil)
+                                    (nreverse name))
+                                   ((atom tail)
+                                    (nconc (nreverse name) (walk tail)))
+                                   (t
+                                    (setf *debug-name-punt* t)
+                                    (nconc (nreverse name) (list *debug-name-ellipsis*)))))))
+                      *debug-name-sharp*))
+                 ((or symbol number string)
+                  x)
+                 (t
+                  (type-of x)))))
+      (let ((name (list type (walk thing))))
+        (when (legal-fun-name-p name)
+          (bug "~S is a legal function name, and cannot be used as a ~
+                debug name." name))
+        name))))
diff --git a/version.lisp-expr b/version.lisp-expr
index c295d94a0..253e9e680 100644
--- a/version.lisp-expr
+++ b/version.lisp-expr
@@ -17,4 +17,4 @@
 ;;; checkins which aren't released. (And occasionally for internal
 ;;; versions, especially for internal versions off the main CVS
 ;;; branch, it gets hairier, e.g. "0.pre7.14.flaky4.13".)
-"1.0.13.33"
+"1.0.13.34"
-- 
2.11.4.GIT