| commit | 4a5794447a682b8034b2381054df28bd6296c4ee | |
| author | Eric Wong <normalperson@yhbt.net> | |
| Tue, 23 Dec 2008 02:28:27 +0000 (22 18:28 -0800) | ||
| committer | Eric Wong <normalperson@yhbt.net> | |
| Tue, 23 Dec 2008 02:39:14 +0000 (22 18:39 -0800) | ||
| tree | c97a619da3a27b6b818714e2b083ce0ff8ffe5f5 | treesnapshot (tar.gz zip) |
| parent | b7ba273a043633c01d9ae8cda8ae9db4cc5dcf07 | commitdiff |
Replace TCPSocket + timeout code with Socket + IO.select
This removes the dependency on unsafe methods used in the
Timeout class.
Charles makes some good points here:
http://blog.headius.com/2008/02/rubys-threadraise-threadkill-timeoutrb.html
And even matz agrees:
http://blade.nagaokaut.ac.jp/cgi-bin/scat.rb/ruby/ruby-talk/294446
Of course, I strongly dislike any unnecessary use of threads,
and implementations using native threads to do timeouts makes me
even more uncomfortable.
This removes the dependency on unsafe methods used in the
Timeout class.
Charles makes some good points here:
http://blog.headius.com/2008/02/rubys-threadraise-threadkill-timeoutrb.html
And even matz agrees:
http://blade.nagaokaut.ac.jp/cgi-bin/scat.rb/ruby/ruby-talk/294446
Of course, I strongly dislike any unnecessary use of threads,
and implementations using native threads to do timeouts makes me
even more uncomfortable.