| commit | d5aebef884cabf197d51d2066a5beee8d0c721d4 | |
| author | Eduardo Habkost <ehabkost@redhat.com> | |
| Mon, 6 Jun 2016 15:53:54 +0000 (6 12:53 -0300) | ||
| committer | Peter Maydell <peter.maydell@linaro.org> | |
| Tue, 7 Jun 2016 14:00:02 +0000 (7 15:00 +0100) | ||
| tree | b4320b8e891dcfb10bca1467cbee07d6772707e3 | treesnapshot (tar.gz zip) |
| parent | 0601d6a4112a5b0333d2348aa2c3465cc0075ec6 | commitdiff |
docker: Don't use eval trick on Makefile
The eval trick for defining DOCKER_SRC_COPY doesn't do anything
useful, as DOCKER_SRC_COPY is immediately expanded just after it
is defined, and CUR_TIME is already defined using ":=". Simply
define it using ":=" so it is evaluated only once.
The eval trick was also triggering an weird error on Travis builds:
qemu/tests/docker/Makefile.include:34: *** unterminated variable reference. Stop.
The issue is not easily reproducible (maybe it's a bug in some
versions of Make), but it is avoided if removing the eval trick.
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
The eval trick for defining DOCKER_SRC_COPY doesn't do anything
useful, as DOCKER_SRC_COPY is immediately expanded just after it
is defined, and CUR_TIME is already defined using ":=". Simply
define it using ":=" so it is evaluated only once.
The eval trick was also triggering an weird error on Travis builds:
qemu/tests/docker/Makefile.include:34: *** unterminated variable reference. Stop.
The issue is not easily reproducible (maybe it's a bug in some
versions of Make), but it is avoided if removing the eval trick.
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
| tests/docker/Makefile.include | diffblobblamehistory |