| commit | 8b7bf2badac25c0a52aff1b181ad75fdb304dd0c | |
| author | Dr. David Alan Gilbert <dgilbert@redhat.com> | |
| Mon, 30 Apr 2018 18:59:43 +0000 (30 19:59 +0100) | ||
| committer | Juan Quintela <quintela@redhat.com> | |
| Tue, 15 May 2018 20:13:08 +0000 (15 22:13 +0200) | ||
| tree | 6bc44dca41c05e82f01f3f5521d3f455a60c3c3d | treesnapshot (tar.gz zip) |
| parent | 5e50cae409a0f43332efe594a67827cb4ee66c28 | commitdiff |
Migration+TLS: Fix crash due to double cleanup
During a TLS connect we see:
migration_channel_connect calls
migration_tls_channel_connect
(calls after TLS setup)
migration_channel_connect
My previous error handling fix made migration_channel_connect
call migrate_fd_connect in all cases; unfortunately the above
means it gets called twice and crashes doing double cleanup.
Fixes: 688a3dcba98
Reported-by: Peter Krempa <pkrempa@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20180430185943.35714-1-dgilbert@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
During a TLS connect we see:
migration_channel_connect calls
migration_tls_channel_connect
(calls after TLS setup)
migration_channel_connect
My previous error handling fix made migration_channel_connect
call migrate_fd_connect in all cases; unfortunately the above
means it gets called twice and crashes doing double cleanup.
Fixes: 688a3dcba98
Reported-by: Peter Krempa <pkrempa@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20180430185943.35714-1-dgilbert@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
| migration/channel.c | diffblobblamehistory |