qdev_try_create(): Assert that devices we put onto the system bus are SysBusDevices
commit7474f1be701f136b224af5e1abe55e97dc3f29a5
authorPeter Maydell <peter.maydell@linaro.org>
Tue, 10 May 2016 10:30:42 +0000 (10 11:30 +0100)
committerPeter Maydell <peter.maydell@linaro.org>
Tue, 14 Jun 2016 14:07:43 +0000 (14 15:07 +0100)
tree3b35f2e3610b34a380a8b3e3a12f73eab9bf82b8
parentd32490ca74c700edc74f0b2f6b7536b52a644739
qdev_try_create(): Assert that devices we put onto the system bus are SysBusDevices

If qdev_try_create() is passed NULL for the bus, it will automatically
put the newly created device onto the default system bus. However
if the device is not actually a SysBusDevice then this will result
in later crashes (for instance when running the monitor "info qtree"
command) because code reasonably assumes that all devices on the system
bus are system bus devices.

Generally the mistake is that the calling code should create the
object with object_new(TYPE_FOO) rather than qdev_create(NULL, TYPE_FOO);
see commit 6749695eaaf346c1 for an example of fixing this bug.

Assert in qdev_try_create() if the device isn't suitable to put on
the system bus, so that this mistake results in failure earlier
and more reliably.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
hw/core/qdev.c