ui/gtk: prevent ui lock up when dpy_gl_update called again before current draw event...
commit64f1359bd08060ffe7a5689fdcbaeec6d8a59980
authorDongwon Kim <dongwon.kim@intel.com>
Fri, 21 Oct 2022 19:23:15 +0000 (21 12:23 -0700)
committerGerd Hoffmann <kraxel@redhat.com>
Wed, 23 Nov 2022 11:27:55 +0000 (23 12:27 +0100)
tree75ee2c1467ceddc05c35d4fba601ca40e61b42a9
parentd68640f515320bf38617b68c970b569997cf0444
ui/gtk: prevent ui lock up when dpy_gl_update called again before current draw event occurs

A warning, "qemu: warning: console: no gl-unblock within" followed by
guest scanout lockup can happen if dpy_gl_update is called in a row
and the second call is made before gd_draw_event scheduled by the first
call is taking place. This is because draw call returns without decrementing
gl_block ref count if the dmabuf was already submitted as shown below.

(gd_gl_area_draw/gd_egl_draw)

        if (dmabuf) {
            if (!dmabuf->draw_submitted) {
                return;
            } else {
                dmabuf->draw_submitted = false;
            }
        }

So it should not schedule any redundant draw event in case draw_submitted is
already set in gd_egl_fluch/gd_gl_area_scanout_flush.

Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Vivek Kasireddy <vivek.kasireddy@intel.com>
Signed-off-by: Dongwon Kim <dongwon.kim@intel.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20221021192315.9110-1-dongwon.kim@intel.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
ui/gtk-egl.c
ui/gtk-gl-area.c