| commit | ba4b3f668abf1fcde204c8f3185ea6edeec6eaa3 | |
| author | Peter Maydell <peter.maydell@linaro.org> | |
| Tue, 12 Jul 2016 12:02:19 +0000 (12 13:02 +0100) | ||
| committer | Riku Voipio <riku.voipio@linaro.org> | |
| Thu, 4 Aug 2016 13:35:30 +0000 (4 16:35 +0300) | ||
| tree | 11ec68a1e5bf6aad9d4c73de9b00d5281baa0bf4 | treesnapshot (tar.gz zip) |
| parent | d9fe91d8689b078acfd27bc7c4a4e1efd5bbcf65 | commitdiff |
linux-user: Fix memchr() argument in open_self_cmdline()
In open_self_cmdline() we look for a 0 in the buffer we read
from /prc/self/cmdline. We were incorrectly passing the length
of our buf[] array to memchr() as the length to search, rather
than the number of bytes we actually read into it, which could
be shorter. This was spotted by Coverity (because it could
result in our trying to pass a negative length argument to
write()).
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
In open_self_cmdline() we look for a 0 in the buffer we read
from /prc/self/cmdline. We were incorrectly passing the length
of our buf[] array to memchr() as the length to search, rather
than the number of bytes we actually read into it, which could
be shorter. This was spotted by Coverity (because it could
result in our trying to pass a negative length argument to
write()).
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
| linux-user/syscall.c | diffblobblamehistory |