| commit | 0f4b210e504d7db42b96882e94481f444e420fe3 | |
| author | Eduardo Habkost <ehabkost@redhat.com> | |
| Wed, 4 Mar 2015 01:54:03 +0000 (3 22:54 -0300) | ||
| committer | Eduardo Habkost <ehabkost@redhat.com> | |
| Mon, 9 Mar 2015 19:30:02 +0000 (9 16:30 -0300) | ||
| tree | 8b65f90baf7226183a29b7272f351836fa9ae0b9 | treesnapshot (tar.gz zip) |
| parent | 5eb2f7a4df03b53f7eaf56d2dd53d75328909826 | commitdiff |
target-i386: Remove unused APIC ID default code
The existing apic_id = cpu_index code has no visible effect: the PC code
already initializes the APIC ID according to the topology on
pc_new_cpu(), and linux-user memcpy()s the CPU state (including
cpuid_apic_id) on cpu_copy().
Remove the dead code and simply let APIC ID to to be 0 by default. This
doesn't change behavior of PC because apic-id is already explicitly set,
and doesn't affect linux-user because APIC ID was already always 0.
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Andreas Färber <afaerber@suse.de>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
The existing apic_id = cpu_index code has no visible effect: the PC code
already initializes the APIC ID according to the topology on
pc_new_cpu(), and linux-user memcpy()s the CPU state (including
cpuid_apic_id) on cpu_copy().
Remove the dead code and simply let APIC ID to to be 0 by default. This
doesn't change behavior of PC because apic-id is already explicitly set,
and doesn't affect linux-user because APIC ID was already always 0.
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Andreas Färber <afaerber@suse.de>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
| target-i386/cpu.c | diffblobblamehistory |