9pfs: only free completed request if not flushed
commitf74e27bf0f07425aba6cb812aa7f5aa98bb68542
authorGreg Kurz <groug@kaod.org>
Mon, 17 Oct 2016 12:13:58 +0000 (17 14:13 +0200)
committerGreg Kurz <groug@kaod.org>
Mon, 17 Oct 2016 12:13:58 +0000 (17 14:13 +0200)
treef1517f5ea21a08ba1e052b5e2bcac08d7a117d1b
parent6868a420c519d74926ea814d48f6ce9beda35b98
9pfs: only free completed request if not flushed

If a PDU has a flush request pending, the current code calls pdu_free()
twice:

1) pdu_complete()->pdu_free() with pdu->cancelled set, which does nothing

2) v9fs_flush()->pdu_free() with pdu->cancelled cleared, which moves the
   PDU back to the free list.

This works but it complexifies the logic of pdu_free().

With this patch, pdu_complete() only calls pdu_free() if no flush request
is pending, i.e. qemu_co_queue_next() returns false.

Since pdu_free() is now supposed to be called with pdu->cancelled cleared,
the check in pdu_free() is dropped and replaced by an assertion.

Signed-off-by: Greg Kurz <groug@kaod.org>
hw/9pfs/9p.c