spapr: Assert DIMM unplug state in spapr_memory_unplug()
commitdf2d7ca7744156aac0e05ab47bc8623654c1346a
authorGreg Kurz <groug@kaod.org>
Sat, 13 Mar 2021 07:23:31 +0000 (13 08:23 +0100)
committerDavid Gibson <david@gibson.dropbear.id.au>
Wed, 31 Mar 2021 00:10:50 +0000 (31 11:10 +1100)
tree97635e4b28ae4c80111b2e53d24b4ed4ad2dfb6f
parent9cbcfb5924b9a8295e7a103941135eb75c9deb93
spapr: Assert DIMM unplug state in spapr_memory_unplug()

spapr_memory_unplug() is the last step of the hot unplug sequence.
It is indirectly called by:

 spapr_lmb_release()
  hotplug_handler_unplug()

and spapr_lmb_release() already buys us that DIMM unplug state is
present : it gets restored with spapr_recover_pending_dimm_state()
if missing.

g_assert() that spapr_pending_dimm_unplugs_find() cannot return NULL
in spapr_memory_unplug() to make this clear and silence Coverity.

Fixes: Coverity CID 1450767
Signed-off-by: Greg Kurz <groug@kaod.org>
Message-Id: <161562021166.948373.15092876234470478331.stgit@bahia.lan>
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
hw/ppc/spapr.c