util: remove the obsolete non-blocking connect
commitb2587932582333197c88bf663785b19f441989d7
authorCao jin <caoj.fnst@cn.fujitsu.com>
Fri, 16 Jun 2017 08:54:45 +0000 (16 16:54 +0800)
committerDaniel P. Berrange <berrange@redhat.com>
Tue, 5 Sep 2017 12:21:58 +0000 (5 13:21 +0100)
tree2ef4ff597cc77de171acf83a1748f76fa2d6edca
parentd4adf9675801cd90e66ecfcd6a54ca1abc5a6698
util: remove the obsolete non-blocking connect

The non-blocking connect mechanism is obsolete, and it doesn't
work well in inet connection, because it will call getaddrinfo
first and getaddrinfo will blocks on DNS lookups. Since commit
e65c67e4 & d984464e, the non-blocking connect of migration goes
through QIOChannel in a different manner(using a thread), and
nobody use this old non-blocking connect anymore.

Any newly written code which needs a non-blocking connect should
use the QIOChannel code, so we can drop NonBlockingConnectHandler
as a concept entirely.

Suggested-by: Daniel P. Berrange <berrange@redhat.com>
Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
Signed-off-by: Mao Zhongyi <maozy.fnst@cn.fujitsu.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
block/sheepdog.c
block/ssh.c
include/qemu/sockets.h
io/channel-socket.c
util/qemu-sockets.c