| commit | a890557d5a90b2c99988bc478bfd7f77392cfd8d | |
| author | Greg Kurz <groug@kaod.org> | |
| Fri, 12 Mar 2021 09:22:06 +0000 (12 10:22 +0100) | ||
| committer | Michael S. Tsirkin <mst@redhat.com> | |
| Mon, 22 Mar 2021 14:17:53 +0000 (22 10:17 -0400) | ||
| tree | 0cb03f4fa759cef8ab01582dfb28ac29235cce94 | treesnapshot (tar.gz zip) |
| parent | 0ab8c021c6c594846915cbeb501fa87ab8780949 | commitdiff |
vhost-user: Drop misleading EAGAIN checks in slave_read()
slave_read() checks EAGAIN when reading or writing to the socket
fails. This gives the impression that the slave channel is in
non-blocking mode, which is certainly not the case with the current
code base. And the rest of the code isn't actually ready to cope
with non-blocking I/O.
Just drop the checks everywhere in this function for the sake of
clarity.
Signed-off-by: Greg Kurz <groug@kaod.org>
Message-Id: <20210312092212.782255-2-groug@kaod.org>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
slave_read() checks EAGAIN when reading or writing to the socket
fails. This gives the impression that the slave channel is in
non-blocking mode, which is certainly not the case with the current
code base. And the rest of the code isn't actually ready to cope
with non-blocking I/O.
Just drop the checks everywhere in this function for the sake of
clarity.
Signed-off-by: Greg Kurz <groug@kaod.org>
Message-Id: <20210312092212.782255-2-groug@kaod.org>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
| hw/virtio/vhost-user.c | diffblobblamehistory |