migration/rdma: Simplify the function that saves a page
commit9c53d369e5903375a2e3358f739be77dcb8dae49
authorJuan Quintela <quintela@redhat.com>
Mon, 15 May 2023 19:57:08 +0000 (15 21:57 +0200)
committerJuan Quintela <quintela@redhat.com>
Fri, 29 Sep 2023 16:13:53 +0000 (29 18:13 +0200)
tree0d15f5d95f13d2a88c7145ccbaee42a49237dbbc
parent9f51fe92392f601a177687bef01a545298cb47e1
migration/rdma: Simplify the function that saves a page

When we sent a page through QEMUFile hooks (RDMA) there are three
posiblities:
- We are not using RDMA. return RAM_SAVE_CONTROL_DELAYED and
  control_save_page() returns false to let anything else to proceed.
- There is one error but we are using RDMA.  Then we return a negative
  value, control_save_page() needs to return true.
- Everything goes well and RDMA start the sent of the page
  asynchronously.  It returns RAM_SAVE_CONTROL_DELAYED and we need to
  return 1 for ram_save_page_legacy.

Clear?

I know, I know, the interface is as bad as it gets.  I think that now
it is a bit clearer, but this needs to be done some other way.

Reviewed-by: Leonardo Bras <leobras@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
Message-Id: <20230515195709.63843-16-quintela@redhat.com>
migration/qemu-file.c
migration/qemu-file.h
migration/ram.c
migration/rdma.c