virtio-serial: avoid crash when port has no name
commit7eb7311427a6e2a9e080c1224f86a897f077282f
authorMarc-André Lureau <marcandre.lureau@gmail.com>
Wed, 5 Nov 2014 14:43:14 +0000 (5 15:43 +0100)
committerAmit Shah <amit.shah@redhat.com>
Fri, 7 Nov 2014 04:57:11 +0000 (7 10:27 +0530)
tree5fdf8404ad728224d55a160d8f2f5a3887856c38
parent6e76d125f244e10676b917208f2a074729820246
virtio-serial: avoid crash when port has no name

It seems "name" is not mandatory, and the following command line (based
on one generated by current libvirt) will crash qemu at start:

qemu-system-x86_64 \
    -device virtio-serial-pci \
    -device virtserialport,name=foo \
    -device virtconsole

Program received signal SIGSEGV, Segmentation fault.
__strcmp_ssse3 () at ../sysdeps/x86_64/strcmp.S:210
210        movlpd    (%rsi), %xmm2
Missing separate debuginfos, use: debuginfo-install
python-libs-2.7.5-13.fc20.x86_64
(gdb) bt
 #0  __strcmp_ssse3 () at ../sysdeps/x86_64/strcmp.S:210
 #1  0x000055555566bdc6 in find_port_by_name (name=0x0) at /home/elmarco/src/qemu/hw/char/virtio-serial-bus.c:67

Signed-off-by: Marc-André Lureau <marcandre.lureau@gmail.com>
Reviewed-by: Amos Kong <akong@redhat.com>
Signed-off-by: Amit Shah <amit.shah@redhat.com>
hw/char/virtio-serial-bus.c