block: Update open_flags after ->inactivate() callback
commit7d5b5261104235cd6cc86930ab0d0a7372bfe04b
authorStefan Hajnoczi <stefanha@redhat.com>
Wed, 23 Aug 2017 13:42:42 +0000 (23 21:42 +0800)
committerEric Blake <eblake@redhat.com>
Wed, 23 Aug 2017 15:21:55 +0000 (23 10:21 -0500)
tree37971b3c72b983c6981805c44d676557adb37b4d
parent045a2f8254c64c4de32a8dc3671a93d4bfd04ee7
block: Update open_flags after ->inactivate() callback

In the ->inactivate() callbacks, permissions are updated, which
typically involves a recursive check of the whole graph. Setting
BDRV_O_INACTIVE right before doing that creates a state that
bdrv_is_writable() returns false, which causes permission update
failure.

Reorder them so the flag is updated after calling the function. Note
that this doesn't break the assert in bdrv_child_cb_inactivate() because
for any specific BDS, we still update its flags first before calling
->inactivate() on it one level deeper in the recursion.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Fam Zheng <famz@redhat.com>
Message-Id: <20170823134242.12080-5-famz@redhat.com>
Tested-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Eric Blake <eblake@redhat.com>
block.c