sclpconsolelm: remove bogus check for -EAGAIN
commit7983e829336f68b6df6952dd4b03493b1486fcf5
authorDaniel P. Berrange <berrange@redhat.com>
Tue, 6 Sep 2016 13:56:03 +0000 (6 14:56 +0100)
committerPaolo Bonzini <pbonzini@redhat.com>
Tue, 13 Sep 2016 17:09:42 +0000 (13 19:09 +0200)
treec33805ada081b4e50c17c6deab795545f5384c63
parentb72981b910097b31f4d0b9c111a2d2cfd9ee585b
sclpconsolelm: remove bogus check for -EAGAIN

The write_console_data() method in sclpconsole-lm.c checks
whether the return value of qemu_chr_fe_write() has the
value of -EAGAIN and if so then increments the buffer offset
by the value of EAGAIN. Fortunately qemu_chr_fe_write() will
never return EAGAIN directly, rather it returns -1 with
errno set to EAGAIN, so this broken code path was not
reachable. The behaviour on EAGAIN was stil bad though,
causing the write_console_data() to busy_wait repeatedly
calling qemu_chr_fe_write() with no sleep between iters.

Just remove all this loop logic and replace with a call
to qemu_chr_fe_write_all().

Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
Message-Id: <1473170165-540-3-git-send-email-berrange@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
hw/char/sclpconsole-lm.c