| commit | 719fc28c80a22ab9f1533d775bae09c14442bbbe | |
| author | Jeff Cody <jcody@redhat.com> | |
| Wed, 7 Jun 2017 13:55:22 +0000 (7 09:55 -0400) | ||
| committer | Kevin Wolf <kwolf@redhat.com> | |
| Fri, 9 Jun 2017 11:46:20 +0000 (9 13:46 +0200) | ||
| tree | ea8335b88bafab71799c7e85b1bcd96bf474ef3a | treesnapshot (tar.gz zip) |
| parent | 272545cf215f183ecb84c1d0fca3fd38db806977 | commitdiff |
block: fix external snapshot abort permission error
In external_snapshot_abort(), we try to undo what was done in
external_snapshot_prepare() calling bdrv_replace_node() to swap the
nodes back. However, we receive a permissions error as writers are
blocked on the old node, which is now the new node backing file.
An easy fix (initially suggested by Kevin Wolf) is to call
bdrv_set_backing_hd() on the new node, to set the backing node to NULL.
Signed-off-by: Jeff Cody <jcody@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
In external_snapshot_abort(), we try to undo what was done in
external_snapshot_prepare() calling bdrv_replace_node() to swap the
nodes back. However, we receive a permissions error as writers are
blocked on the old node, which is now the new node backing file.
An easy fix (initially suggested by Kevin Wolf) is to call
bdrv_set_backing_hd() on the new node, to set the backing node to NULL.
Signed-off-by: Jeff Cody <jcody@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
| blockdev.c | diffblobblamehistory |