sockets: avoid formatting buffer that may not be NUL terminated
commit56382bd5770decbf7ede46e5030e8e348b27009d
authorDaniel P. Berrange <berrange@redhat.com>
Mon, 26 Jun 2017 10:37:56 +0000 (26 11:37 +0100)
committerPaolo Bonzini <pbonzini@redhat.com>
Tue, 4 Jul 2017 12:39:27 +0000 (4 14:39 +0200)
tree4646a2125de255d1ed831598b99a4274cf94e451
parent24f7ca4907a779568153056eafa6da21cb84dc91
sockets: avoid formatting buffer that may not be NUL terminated

The 'sun_path' field in the sockaddr_un struct is not required
to be NUL termianted, so when reporting an error, we must use
the separate 'path' variable which is guaranteed terminated.

Fixes a bug spotted by coverity that was introduced in

  commit ad9579aaa16d5b385922d49edac2c96c79bcfb62
  Author: Daniel P. Berrange <berrange@redhat.com>
  Date:   Thu May 25 16:53:00 2017 +0100

    sockets: improve error reporting if UNIX socket path is too long

Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
Message-Id: <20170626103756.22974-1-berrange@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
util/qemu-sockets.c