PPC/KVM: early validation of vcpu id
commit41264b385c2b324fea026204e5de9bef980733b1
authorGreg Kurz <gkurz@linux.vnet.ibm.com>
Tue, 26 Apr 2016 13:41:04 +0000 (26 15:41 +0200)
committerDavid Gibson <david@gibson.dropbear.id.au>
Thu, 26 May 2016 23:40:23 +0000 (27 09:40 +1000)
tree2284acef24028c8f0ab0a642dc9516dcc62a8ae7
parent8afc22a20fba6aa078e4e7a625d16d78da768323
PPC/KVM: early validation of vcpu id

The KVM API restricts vcpu ids to be < KVM_CAP_MAX_VCPUS. On PowerPC
targets, depending on the number of threads per core in the host and
in the guest, some topologies do generate higher vcpu ids actually.
When this happens, QEMU bails out with the following error:

kvm_init_vcpu failed: Invalid argument

The KVM_CREATE_VCPU ioctl has several EINVAL return paths, so it is
not possible to fully disambiguate.

This patch adds a check in the code that computes vcpu ids, so that
we can detect the error earlier, and print a friendlier message instead
of calling KVM_CREATE_VCPU with an obviously bogus vcpu id.

Signed-off-by: Greg Kurz <gkurz@linux.vnet.ibm.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
include/sysemu/kvm.h
kvm-all.c
target-ppc/translate_init.c