migration: Set migration status early in incoming side
commit4111a732e80894256c9053577f0e9369eeea807b
authorFabiano Rosas <farosas@suse.de>
Wed, 12 Jul 2023 19:07:40 +0000 (12 16:07 -0300)
committerJuan Quintela <quintela@redhat.com>
Wed, 11 Oct 2023 09:17:02 +0000 (11 11:17 +0200)
treec914c6a0ed111c3c9105f4f525f9d312322d15e9
parent6830e53b4bd96fe00b72730a3546c5b65ea840a6
migration: Set migration status early in incoming side

We are sending a migration event of MIGRATION_STATUS_SETUP at
qemu_start_incoming_migration but never actually setting the state.

This creates a window between qmp_migrate_incoming and
process_incoming_migration_co where the migration status is still
MIGRATION_STATUS_NONE. Calling query-migrate during this time will
return an empty response even though the incoming migration command
has already been issued.

Commit 7cf1fe6d68 ("migration: Add migration events on target side")
has added support to the 'events' capability to the incoming part of
migration, but chose to send the SETUP event without setting the
state. I'm assuming this was a mistake.

This introduces a change in behavior, any QMP client waiting for the
SETUP event will hang, unless it has previously enabled the 'events'
capability. Having the capability enabled is sufficient to continue to
receive the event.

Reviewed-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Fabiano Rosas <farosas@suse.de>
Signed-off-by: Juan Quintela <quintela@redhat.com>
Message-ID: <20230712190742.22294-5-farosas@suse.de>
migration/migration.c