spapr_rng: disable hotpluggability
commit3d0db3e74d818ba43c62cdfb3220e551f4f5ae37
authorGreg Kurz <gkurz@linux.vnet.ibm.com>
Thu, 25 Feb 2016 11:08:00 +0000 (25 12:08 +0100)
committerDavid Gibson <david@gibson.dropbear.id.au>
Sun, 28 Feb 2016 05:19:02 +0000 (28 16:19 +1100)
tree272bb5a6ac6a86abb545b6ce60f5b16be3f023a4
parent6e378dd214fbbae8138ff011ec3de7ddf13a445f
spapr_rng: disable hotpluggability

It is currently possible to hotplug a spapr_rng device but QEMU crashes
when we try to hot unplug:

ERROR:hw/core/qdev.c:295:qdev_unplug: assertion failed: (hotplug_ctrl)
Aborted

This happens because spapr_rng isn't plugged to any bus and sPAPR does
not provide hotplug support for it: qdev_get_hotplug_handler() hence
return NULL and we hit the assertion.

And anyway, it doesn't make much sense to unplug this device since hcalls
cannot be unregistered. Even the idea of hotplugging a RNG device instead
of declaring it on the QEMU command line looks weird.

This patch simply disables hotpluggability for the spapr-rng class.

Signed-off-by: Greg Kurz <gkurz@linux.vnet.ibm.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
hw/ppc/spapr_rng.c