ui: mix misleading comments & return types of VNC I/O helper methods
commit30b80fd5269257f55203b7072c505b4ebaab5115
authorDaniel P. Berrange <berrange@redhat.com>
Mon, 18 Dec 2017 19:12:28 +0000 (18 19:12 +0000)
committerGerd Hoffmann <kraxel@redhat.com>
Fri, 12 Jan 2018 12:48:54 +0000 (12 13:48 +0100)
treed8fc1287d1ec86bd3910ccbc6120f8444b870393
parent6aa22a29187e1908f5db738d27c64a9efc8d0bfa
ui: mix misleading comments & return types of VNC I/O helper methods

While the QIOChannel APIs for reading/writing data return ssize_t, with negative
value indicating an error, the VNC code passes this return value through the
vnc_client_io_error() method. This detects the error condition, disconnects the
client and returns 0 to indicate error. Thus all the VNC helper methods should
return size_t (unsigned), and misleading comments which refer to the possibility
of negative return values need fixing.

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
Reviewed-by: Darren Kenny <darren.kenny@oracle.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-id: 20171218191228.31018-14-berrange@redhat.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
ui/vnc-auth-sasl.c
ui/vnc-auth-sasl.h
ui/vnc.c
ui/vnc.h