block: vhdx - change .vhdx_create default block state to ZERO
commit30af51ce7f4aebb37359367c65b7405451e70702
authorJeff Cody <jcody@redhat.com>
Mon, 8 Dec 2014 06:07:44 +0000 (8 01:07 -0500)
committerStefan Hajnoczi <stefanha@redhat.com>
Fri, 12 Dec 2014 15:42:49 +0000 (12 15:42 +0000)
treecbaaf5c2ae2e3f541bed8354bc5bd8075ef23ec7
parenta9d1e9daa5527101c0b2dcf1a57aab549075144a
block: vhdx - change .vhdx_create default block state to ZERO

The VHDX spec specifies that the default new block state is
PAYLOAD_BLOCK_NOT_PRESENT for a dynamic VHDX image, and
PAYLOAD_BLOCK_FULLY_PRESENT for a fixed VHDX image.

However, in order to create space-efficient VHDX images with qemu-img
convert, it is desirable to be able to set has_zero_init to true for
VHDX.

There is currently an option when creating VHDX images, to use block
state ZERO for new blocks.  However, this currently defaults to 'off'.
In order to be able to eventually set has_zero_init to true for VHDX,
this needs to default to 'on'.

This patch changes the default to 'on', and provides some help
information to warn against setting it to 'off' when using qemu-img
convert.

[Max Reitz pointed out that a full stop was missing at the end of the
VHDX_BLOCK_OPT_ZERO option help text.  I have added it.
--Stefan]

Signed-off-by: Jeff Cody <jcody@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Message-id: 85164899eacc86e150c3ceba793cf93b398dedd7.1418018421.git.jcody@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
block/vhdx.c
qemu-doc.texi