| commit | 191f90cbea08122b48107f1f9116106fbf3bdfac | |
| author | Michael S. Tsirkin <mst@redhat.com> | |
| Thu, 14 May 2020 15:14:39 +0000 (14 11:14 -0400) | ||
| committer | Michael S. Tsirkin <mst@redhat.com> | |
| Tue, 9 Jun 2020 13:31:34 +0000 (9 09:31 -0400) | ||
| tree | 685a202e5a0e5bd477d0c4ad4dc9db9db9c8a205 | treesnapshot (tar.gz zip) |
| parent | 49ee11555262a256afec592dfed7c5902d5eefd2 | commitdiff |
msix: allow qword MSI-X table accesses
PCI spec says:
For all accesses to MSI-X Table and MSI-X PBA fields, software must use
aligned full DWORD or aligned full QWORD transactions; otherwise, the
result is undefined.
However, since MSI-X was converted to use memory API, QEMU
started blocking qword transactions, only allowing DWORD
ones. Guests do not seem to use QWORD accesses, but let's
be spec compliant.
Fixes: 95524ae8dc8f ("msix: convert to memory API")
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
PCI spec says:
For all accesses to MSI-X Table and MSI-X PBA fields, software must use
aligned full DWORD or aligned full QWORD transactions; otherwise, the
result is undefined.
However, since MSI-X was converted to use memory API, QEMU
started blocking qword transactions, only allowing DWORD
ones. Guests do not seem to use QWORD accesses, but let's
be spec compliant.
Fixes: 95524ae8dc8f ("msix: convert to memory API")
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
| hw/pci/msix.c | diffblobblamehistory |