| commit | 1718f238d1ee3c40496a36d6e4dc88ad21a04896 | |
| author | Markus Armbruster <armbru@redhat.com> | |
| Thu, 28 Sep 2023 13:19:57 +0000 (28 15:19 +0200) | ||
| committer | Juan Quintela <quintela@redhat.com> | |
| Wed, 11 Oct 2023 09:17:03 +0000 (11 11:17 +0200) | ||
| tree | d03deab0ffc80303c5b61ca27469f9b8f360f28b | treesnapshot (tar.gz zip) |
| parent | e518b0050d41adf764aa06373acf0fbd696b8a0e | commitdiff |
migration/rdma: Delete inappropriate error_report() in macro ERROR()
Functions that use an Error **errp parameter to return errors should
not also report them to the user, because reporting is the caller's
job. When the caller does, the error is reported twice. When it
doesn't (because it recovered from the error), there is no error to
report, i.e. the report is bogus.
Macro ERROR() violates this principle. Delete the error_report()
there.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Li Zhijian <lizhijian@fujitsu.com>
Tested-by: Li Zhijian <lizhijian@fujitsu.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
Message-ID: <20230928132019.2544702-32-armbru@redhat.com>
Functions that use an Error **errp parameter to return errors should
not also report them to the user, because reporting is the caller's
job. When the caller does, the error is reported twice. When it
doesn't (because it recovered from the error), there is no error to
report, i.e. the report is bogus.
Macro ERROR() violates this principle. Delete the error_report()
there.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Li Zhijian <lizhijian@fujitsu.com>
Tested-by: Li Zhijian <lizhijian@fujitsu.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
Message-ID: <20230928132019.2544702-32-armbru@redhat.com>
| migration/rdma.c | diffblobblamehistory |