pci: Convert msi_init() to Error and fix callers to check it
commit1108b2f8a939fb5778d384149e2f1b99062a72da
authorCao jin <caoj.fnst@cn.fujitsu.com>
Mon, 20 Jun 2016 06:13:39 +0000 (20 14:13 +0800)
committerMichael S. Tsirkin <mst@redhat.com>
Tue, 5 Jul 2016 10:14:41 +0000 (5 13:14 +0300)
tree0b53cef98d45fdd66c95053a110ada727a743c1b
parent69b205bb0b9ecf65b0ded7b9219ef9a58ef322ad
pci: Convert msi_init() to Error and fix callers to check it

msi_init() reports errors with error_report(), which is wrong
when it's used in realize().

Fix by converting it to Error.

Fix its callers to handle failure instead of ignoring it.

For those callers who don't handle the failure, it might happen:
when user want msi on, but he doesn't get what he want because of
msi_init fails silently.

cc: Gerd Hoffmann <kraxel@redhat.com>
cc: John Snow <jsnow@redhat.com>
cc: Dmitry Fleytman <dmitry@daynix.com>
cc: Jason Wang <jasowang@redhat.com>
cc: Michael S. Tsirkin <mst@redhat.com>
cc: Hannes Reinecke <hare@suse.de>
cc: Paolo Bonzini <pbonzini@redhat.com>
cc: Alex Williamson <alex.williamson@redhat.com>
cc: Markus Armbruster <armbru@redhat.com>
cc: Marcel Apfelbaum <marcel@redhat.com>

Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Hannes Reinecke <hare@suse.com>
15 files changed:
hw/audio/intel-hda.c
hw/ide/ich.c
hw/net/e1000e.c
hw/net/vmxnet3.c
hw/pci-bridge/ioh3420.c
hw/pci-bridge/pci_bridge_dev.c
hw/pci-bridge/xio3130_downstream.c
hw/pci-bridge/xio3130_upstream.c
hw/pci/msi.c
hw/scsi/megasas.c
hw/scsi/mptsas.c
hw/scsi/vmw_pvscsi.c
hw/usb/hcd-xhci.c
hw/vfio/pci.c
include/hw/pci/msi.h