vl: exit if a bad property value is passed to -global
commit03f28efbbb0ee521611e0eb28b45096b3598fb34
authorGreg Kurz <groug@kaod.org>
Thu, 21 Jul 2016 22:00:57 +0000 (22 00:00 +0200)
committerEduardo Habkost <ehabkost@redhat.com>
Wed, 27 Jul 2016 14:25:06 +0000 (27 11:25 -0300)
tree68510b455dee660280eb7371d35a5d982d2e3f36
parentb3443f43f45e06971d87c985bb0316c1e40259c9
vl: exit if a bad property value is passed to -global

When passing '-global driver=host-powerpc64-cpu,property=compat,value=foo'
on the command line, without this patch, we get the following warning per
device (which means many lines if the guests has many cpus):

qemu-system-ppc64: Warning: can't apply global host-powerpc64-cpu.compat=foo:
    Invalid compatibility mode "foo"

... and QEMU continues execution, ignoring the property.

With this patch, we get a single line:

qemu-system-ppc64: can't apply global host-powerpc64-cpu.compat=foo:
    Invalid compatibility mode "foo"

... and QEMU exits.

The previous behavior is kept for hotplugged devices since we don't want
QEMU to exit when doing device_add.

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
vl.c