| commit | eecbb9fe6f9a9cffd8d305f688b1be27d197a253 | |
| author | Markus Armbruster <armbru@redhat.com> | |
| Fri, 29 Jan 2010 18:48:58 +0000 (29 19:48 +0100) | ||
| committer | Anthony Liguori <aliguori@us.ibm.com> | |
| Wed, 3 Feb 2010 18:39:01 +0000 (3 12:39 -0600) | ||
| tree | d2c5b5521e492a5277c4fc7d6ee7e91a4b9f9e82 | treesnapshot (tar.gz zip) |
| parent | ff952ba25deb927fea0b30b8a74e0059a47c1ef1 | commitdiff |
Revert "qdev: Add help for property value"
This reverts commit 922910ce42d15bdb7c2347436b1b5798b5401de4.
The commit has four issues:
* When it runs from the monitor, e.g. "device_add e1000,mac=?", it
prints to stderr instead of the monitor.
* Help looks to callers just like failed device creation. This makes
main() exit unsuccessfully on "-device e1000,mac=?".
* It has an undocumented side effect on -global: "-global e1000.mac=?"
prints help, but only when we actually add an e1000 device.
* It does not work for properties that accept the value "?".
We need to do this differently.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
This reverts commit 922910ce42d15bdb7c2347436b1b5798b5401de4.
The commit has four issues:
* When it runs from the monitor, e.g. "device_add e1000,mac=?", it
prints to stderr instead of the monitor.
* Help looks to callers just like failed device creation. This makes
main() exit unsuccessfully on "-device e1000,mac=?".
* It has an undocumented side effect on -global: "-global e1000.mac=?"
prints help, but only when we actually add an e1000 device.
* It does not work for properties that accept the value "?".
We need to do this differently.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
| hw/qdev-properties.c | diffblobblamehistory |