| commit | c951d9a6751576a076ac80a5e5145ceb8d794d38 | |
| author | Markus Armbruster <armbru@redhat.com> | |
| Wed, 16 Nov 2011 14:43:47 +0000 (16 15:43 +0100) | ||
| committer | Stefan Hajnoczi <stefanha@linux.vnet.ibm.com> | |
| Thu, 17 Nov 2011 12:57:49 +0000 (17 12:57 +0000) | ||
| tree | 3fb2ec211e17e11476872061d70a7056b72ba8d2 | treesnapshot (tar.gz zip) |
| parent | e6d89f8c2518763b4d84f05a10d3fca02b9c8182 | commitdiff |
monitor: Fix file_completion() to check for stat() failure
stat() can fail for a file name just read with readdir(). Easiest way
to trigger is a dangling symbolic link --- look ma, no race! When it
fails, file_completion() uses sb.st_mode uninitialized. If the
directory bit happens to be set, it appends a "/" to the completed
name.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
stat() can fail for a file name just read with readdir(). Easiest way
to trigger is a dangling symbolic link --- look ma, no race! When it
fails, file_completion() uses sb.st_mode uninitialized. If the
directory bit happens to be set, it appends a "/" to the completed
name.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
| monitor.c | diffblobblamehistory |