libqos: Correct error in PCI hole sizing for spapr
commitc711369087d5964ea77b0fd0e0ff1f268e1a67ee
authorDavid Gibson <david@gibson.dropbear.id.au>
Wed, 12 Oct 2016 02:38:25 +0000 (12 13:38 +1100)
committerDavid Gibson <david@gibson.dropbear.id.au>
Sun, 16 Oct 2016 01:03:09 +0000 (16 12:03 +1100)
tree5b5a7eeec276ba57bec948875d243e8001b90bf7
parentcd1b354ec05035f84bb05f591cb632770ad36e7c
libqos: Correct error in PCI hole sizing for spapr

In pci-spapr.c (as in pci-pc.c from which it was derived), the
pci_hole_start/pci_hole_size and pci_iohole_start/pci_iohole_size pairs[1]
essentially define the region of PCI (not CPU) addresses in which MMIO
or PIO BARs respectively will be allocated.

The size value is relative to the start value.  But in pci-spapr.c it is
set to the entire size of the window supported by the (emulated) hardware,
but the start values are *not* at the beginning of the emulated windows.

That means if you tried to map enough PCI BARs, we'd messily overrun the
IO windows, instead of failing in iomap as we should.

This patch corrects this by calculating the hole sizes from the location
of the window in PCI space and the hole start.

[1] Those are bad names, but that's a problem for another time.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Laurent Vivier <lvivier@redhat.com>
tests/libqos/pci-spapr.c