cpus: use broadcast on qemu_pause_cond
commit96bce6831bd19b61e965384427741d805c7234c3
authorDr. David Alan Gilbert <dgilbert@redhat.com>
Mon, 25 Jan 2016 10:08:18 +0000 (25 10:08 +0000)
committerPaolo Bonzini <pbonzini@redhat.com>
Tue, 26 Jan 2016 14:58:14 +0000 (26 15:58 +0100)
tree097dfcd5e58a6bc0c38fb8b196658daf4f19a1d8
parenta013bd2f7b88c831241b3ad6d5635e9d13a7e3fc
cpus: use broadcast on qemu_pause_cond

Jiri saw a hang on pause_all_vcpus called from postcopy_start,
where the cpus are all apparently stopped ('stopped' flag set)
but pause_all_vcpus is still stuck on a cond_wait on qemu_paused_cond.
We suspect this is happening if a qmp_stop is called at about the
same time as the postcopy code calls that pause_all_vcpus;
although they both should have the main lock held, Paolo spotted
the cond_wait unlocks the global lock so perhaps they both
could end up waiting at the same time?

Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reported-by: Jiri Denemark <jdenemar@redhat.com>
Message-Id: <1453716498-27238-1-git-send-email-dgilbert@redhat.com>
Cc: qemu-stable@nongnu.org
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
cpus.c