block/file-posix: Fix fully preallocated truncate
commit82b45e0a0b824787bd79ce3f6453eaa2afddd138
authorMax Reitz <mreitz@redhat.com>
Wed, 28 Feb 2018 13:13:14 +0000 (28 14:13 +0100)
committerMax Reitz <mreitz@redhat.com>
Tue, 3 Apr 2018 15:39:37 +0000 (3 17:39 +0200)
treec4ee6e328b99659949226314bbf6cdbbee1ed361
parent627f607e3dddb23cef69374c8bfb09a33d19926a
block/file-posix: Fix fully preallocated truncate

Storing the lseek() result in an int results in it overflowing when the
file is at least 2 GB big.  Then, we have a 50 % chance of the result
being "negative" and thus thinking an error occurred when actually
everything went just fine.

So we should use the correct type for storing the result: off_t.

Reported-by: Daniel P. Berrange <berrange@redhat.com>
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1549231
Cc: qemu-stable@nongnu.org
Signed-off-by: Max Reitz <mreitz@redhat.com>
Message-id: 20180228131315.30194-2-mreitz@redhat.com
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
block/file-posix.c