migration: Disable multifd explicitly with compression
commit6f39c90b86b9d3772779f873ed88aaa75a220aba
authorPeter Xu <peterx@redhat.com>
Tue, 4 Oct 2022 18:24:30 +0000 (4 14:24 -0400)
committerJuan Quintela <quintela@redhat.com>
Mon, 21 Nov 2022 10:58:10 +0000 (21 11:58 +0100)
treeebec447dd6fa38366166fa168fbc3834e3f82090
parentcedb70eafb4fd51d9c714981509d97b9f4055be5
migration: Disable multifd explicitly with compression

Multifd thread model does not work for compression, explicitly disable it.

Note that previuosly even we can enable both of them, nothing will go
wrong, because the compression code has higher priority so multifd feature
will just be ignored.  Now we'll fail even earlier at config time so the
user should be aware of the consequence better.

Note that there can be a slight chance of breaking existing users, but
let's assume they're not majority and not serious users, or they should
have found that multifd is not working already.

With that, we can safely drop the check in ram_save_target_page() for using
multifd, because when multifd=on then compression=off, then the removed
check on save_page_use_compression() will also always return false too.

Signed-off-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
migration/migration.c
migration/ram.c