| commit | 3f9cb1c14dc368f41447db5f78d6248c4f100ad4 | |
| author | Naphtali Sprei <nsprei@redhat.com> | |
| Thu, 13 Aug 2009 12:01:20 +0000 (13 15:01 +0300) | ||
| committer | Anthony Liguori <aliguori@us.ibm.com> | |
| Fri, 28 Aug 2009 00:33:16 +0000 (27 19:33 -0500) | ||
| tree | 9be48ef2f56680a5ba032f465cb86ca1a4dd33d1 | treesnapshot (tar.gz zip) |
| parent | 06c79f4ebdddbb55a27e06818eedc614e0e02815 | commitdiff |
hw/eepro100.c: Use extended TBD only where applicable
Bug fix for segfault when run as i82551 HW:
Use Extended TBD only when HW supports it (i82558 and up).
Added assertions to guard from such buffer overflow
Introduce the MAX_TCB_BYTE_COUNT macro
Allocate buf big enough as HW needs (MAX_ETH_FRAME_SIZE -> MAX_TCB_BYTE_COUNT)
I don't feel 100% OK with the "s->device >= i82558B" condition
since it relies on the numeric (hex) value of those defines, which currently
is correct, but changes (which I don't forsee now) might break it.
Signed-off-by: Naphtali Sprei <nsprei@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Bug fix for segfault when run as i82551 HW:
Use Extended TBD only when HW supports it (i82558 and up).
Added assertions to guard from such buffer overflow
Introduce the MAX_TCB_BYTE_COUNT macro
Allocate buf big enough as HW needs (MAX_ETH_FRAME_SIZE -> MAX_TCB_BYTE_COUNT)
I don't feel 100% OK with the "s->device >= i82558B" condition
since it relies on the numeric (hex) value of those defines, which currently
is correct, but changes (which I don't forsee now) might break it.
Signed-off-by: Naphtali Sprei <nsprei@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
| hw/eepro100.c | diffblobblamehistory |