iotests: Add test for COR across nodes
commit3e7a95feb9b5d66cff7fee38b3c423135ed245f6
authorMax Reitz <mreitz@redhat.com>
Sat, 21 Apr 2018 13:29:29 +0000 (21 15:29 +0200)
committerMax Reitz <mreitz@redhat.com>
Tue, 15 May 2018 14:15:21 +0000 (15 16:15 +0200)
tree0291bb7ac5bbfa44f86e3f6f9d57b708d6c34337
parenta62cbac4ce2db79c14ff299e98ee556b57467c19
iotests: Add test for COR across nodes

COR across nodes (that is, you have some filter node between the
actually COR target and the node that performs the COR) cannot reliably
work together with the permission system when there is no explicit COR
node that can request the WRITE_UNCHANGED permission for its child.
This is because COR (currently) sneaks its requests by the usual
permission checks, so it can work without a WRITE* permission; but if
there is a filter node in between, that will re-issue the request, which
then passes through the usual check -- and if nobody has requested a
WRITE_UNCHANGED permission, that check will fail.

There is no real direct fix apart from hoping that there is someone who
has requested that permission; in case of just the qemu-io HMP command
(and no guest device), however, that is not the case.  The real real fix
is to implement the copy-on-read flag through an implicitly added COR
node.  Such a node can request the necessary permissions as shown in
this test.

Signed-off-by: Max Reitz <mreitz@redhat.com>
Message-id: 20180421132929.21610-10-mreitz@redhat.com
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
tests/qemu-iotests/216 [new file with mode: 0755]
tests/qemu-iotests/216.out [new file with mode: 0644]
tests/qemu-iotests/group