| commit | ffe3ce1173e71ca299d08f6542839cc31ea3e3cf | |
| author | Donald Dutile <ddutile@redhat.com> | |
| Wed, 21 Sep 2011 19:25:11 +0000 (21 15:25 -0400) | ||
| committer | Anthony Liguori <aliguori@us.ibm.com> | |
| Fri, 23 Sep 2011 15:55:34 +0000 (23 10:55 -0500) | ||
| tree | ef095af380ee8cdf3ed85e514b12f3c909db50e9 | treesnapshot (tar.gz zip) |
| parent | c1d23eaccc5020bb546a4391a0b2abf8ee861923 | commitdiff |
pci-devfn: check that device/slot number is within range
Need to check that guest slot/device number is not > 31 or walk off
the devfn table when checking if a devfn is available or not in a guest.
before this fix, passing in an addr=abc or addr=34,
can crash qemu, sometimes fail gracefully if data past end
of devfn table fails the availability test.
with this fix, get clean error:
Property 'pci-assign.addr' doesn't take value '34'
also tested when no addr= param passed for guest (pcicfg) address,
and that worked as well.
Signed-off-by: Don Dutile <ddutile@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Need to check that guest slot/device number is not > 31 or walk off
the devfn table when checking if a devfn is available or not in a guest.
before this fix, passing in an addr=abc or addr=34,
can crash qemu, sometimes fail gracefully if data past end
of devfn table fails the availability test.
with this fix, get clean error:
Property 'pci-assign.addr' doesn't take value '34'
also tested when no addr= param passed for guest (pcicfg) address,
and that worked as well.
Signed-off-by: Don Dutile <ddutile@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
| hw/qdev-properties.c | diffblobblamehistory |