From 676f48d77db83c687740955aed6783ea6d326853 Mon Sep 17 00:00:00 2001 From: =?utf8?q?=C3=98yvind=20Harboe?= Date: Wed, 11 Aug 2010 11:00:02 +0200 Subject: [PATCH] debug: use assert's when approperiate MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit error was returned instead of using assert. Signed-off-by: Øyvind Harboe --- src/target/arm_jtag.h | 3 +-- src/target/xscale.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/target/arm_jtag.h b/src/target/arm_jtag.h index 37c228f8e..f58127818 100644 --- a/src/target/arm_jtag.h +++ b/src/target/arm_jtag.h @@ -45,8 +45,7 @@ static inline int arm_jtag_set_instr(struct arm_jtag *jtag_info, /* inline most common code path */ struct jtag_tap *tap; tap = jtag_info->tap; - if (tap == NULL) - return ERROR_FAIL; + assert (tap != NULL); if (buf_get_u32(tap->cur_instr, 0, tap->ir_length) != new_instr) { diff --git a/src/target/xscale.c b/src/target/xscale.c index c0080b2b3..44358bc3f 100644 --- a/src/target/xscale.c +++ b/src/target/xscale.c @@ -160,8 +160,7 @@ static int xscale_verify_pointer(struct command_context *cmd_ctx, static int xscale_jtag_set_instr(struct jtag_tap *tap, uint32_t new_instr, tap_state_t end_state) { - if (tap == NULL) - return ERROR_FAIL; + assert (tap != NULL); if (buf_get_u32(tap->cur_instr, 0, tap->ir_length) != new_instr) { -- 2.11.4.GIT