| commit | f473f84840d0c324df684c49744e32f086595bab | |
| author | Antonio Borneo <borneo.antonio@gmail.com> | |
| Fri, 15 Feb 2019 20:31:02 +0000 (15 21:31 +0100) | ||
| committer | Tomas Vanek <vanekt@fbl.cz> | |
| Mon, 25 Feb 2019 21:54:22 +0000 (25 21:54 +0000) | ||
| tree | 8f36bea37b06f2a0e1eb9c21997070028a32cde1 | treesnapshot (tar.gz zip) |
| parent | 1c6f7075f75db1e4da3b918a8c64f2b178712942 | commitdiff |
aarch64: fix a potential memory leak in aarch64_target_create()
If the function aarch64_target_create() exits for an error, the
value of pointer aarch64 get lost, causing a memory leak.
Move the allocation of aarch64 after the check on the parameters.
While there, add a check on the value returned by calloc().
Issue highlighted by clang 7.0.0.
Change-Id: Ib9ad27f4acd940da308c01fdbf33cfe51ab0c639
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: http://openocd.zylin.com/4924
Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
Tested-by: jenkins
Reviewed-by: Matthias Welwarsky <matthias@welwarsky.de>
If the function aarch64_target_create() exits for an error, the
value of pointer aarch64 get lost, causing a memory leak.
Move the allocation of aarch64 after the check on the parameters.
While there, add a check on the value returned by calloc().
Issue highlighted by clang 7.0.0.
Change-Id: Ib9ad27f4acd940da308c01fdbf33cfe51ab0c639
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: http://openocd.zylin.com/4924
Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
Tested-by: jenkins
Reviewed-by: Matthias Welwarsky <matthias@welwarsky.de>
| src/target/aarch64.c | diffblobblamehistory |