| commit | 4eca579a6edf49ff8cb0872c757165c35013e46d | |
| author | Matt Reimer <mreimer@sdgsystems.com> | |
| Mon, 19 Sep 2011 14:30:13 +0000 (19 10:30 -0400) | ||
| committer | Øyvind Harboe <oyvindharboe@gmail.com> | |
| Tue, 18 Oct 2011 20:32:36 +0000 (18 20:32 +0000) | ||
| tree | 8ad77114f6b073445fb54a64c0c12075c8ba44a1 | treesnapshot (tar.gz zip) |
| parent | 0dac042a107f000936995ea468c3fa02b9896fb6 | commitdiff |
xscale: fix bug in xscale_receive()
The code in xscale_receive() that tries to skip invalid reads (i.e.
reads that don't have the DBG_SR[0] 'valid' bit set) seems to be
wrong, as it only looks at the first word's valid flag rather than
each word's own valid flag. Am I reading the code correctly? If so,
the attached patch should fix it.
If this looks correct, I'll generate a proper patch and commit message.
Matt
Change-Id: I74ebe2ad7a36d340a9dd3b8487578b6ea7f3cf1e
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/32
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
The code in xscale_receive() that tries to skip invalid reads (i.e.
reads that don't have the DBG_SR[0] 'valid' bit set) seems to be
wrong, as it only looks at the first word's valid flag rather than
each word's own valid flag. Am I reading the code correctly? If so,
the attached patch should fix it.
If this looks correct, I'll generate a proper patch and commit message.
Matt
Change-Id: I74ebe2ad7a36d340a9dd3b8487578b6ea7f3cf1e
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Reviewed-on: http://openocd.zylin.com/32
Tested-by: jenkins
Reviewed-by: Øyvind Harboe <oyvindharboe@gmail.com>
| src/target/xscale.c | diffblobblamehistory |