From e56b0fa3727ac26bb47b5d441c75dc5b29772de6 Mon Sep 17 00:00:00 2001 From: rguenth Date: Thu, 12 Jul 2018 07:13:36 +0000 Subject: [PATCH] 2018-07-12 Richard Biener PR c/86453 * c-attribs.c (handle_packed_attribute): Do not build a variant type with TYPE_PACKED, instead ignore the attribute if we may not apply to the original type. * g++.dg/warn/pr86453.C: New testcase. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@262575 138bc75d-0d04-0410-961f-82ee72b054a4 --- gcc/c-family/ChangeLog | 7 +++++++ gcc/c-family/c-attribs.c | 9 +++++++-- gcc/testsuite/ChangeLog | 5 +++++ gcc/testsuite/g++.dg/warn/pr86453.C | 5 +++++ 4 files changed, 24 insertions(+), 2 deletions(-) create mode 100644 gcc/testsuite/g++.dg/warn/pr86453.C diff --git a/gcc/c-family/ChangeLog b/gcc/c-family/ChangeLog index a459f061326..115e032e41d 100644 --- a/gcc/c-family/ChangeLog +++ b/gcc/c-family/ChangeLog @@ -1,3 +1,10 @@ +2018-07-12 Richard Biener + + PR c/86453 + * c-attribs.c (handle_packed_attribute): Do not build a variant + type with TYPE_PACKED, instead ignore the attribute if we may + not apply to the original type. + 2018-07-10 Jakub Jelinek PR c++/86443 diff --git a/gcc/c-family/c-attribs.c b/gcc/c-family/c-attribs.c index f91add488bb..8cb87eb8154 100644 --- a/gcc/c-family/c-attribs.c +++ b/gcc/c-family/c-attribs.c @@ -502,8 +502,13 @@ handle_packed_attribute (tree *node, tree name, tree ARG_UNUSED (args), if (TYPE_P (*node)) { if (!(flags & (int) ATTR_FLAG_TYPE_IN_PLACE)) - *node = build_variant_type_copy (*node); - TYPE_PACKED (*node) = 1; + { + warning (OPT_Wattributes, + "%qE attribute ignored for type %qT", name, *node); + *no_add_attrs = true; + } + else + TYPE_PACKED (*node) = 1; } else if (TREE_CODE (*node) == FIELD_DECL) { diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 0958a1a57b2..d68cccf3d0b 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,5 +1,10 @@ 2018-07-12 Richard Biener + PR c/86453 + * g++.dg/warn/pr86453.C: New testcase. + +2018-07-12 Richard Biener + PR middle-end/86479 * gcc.dg/graphite/pr86479.c: New testcase. diff --git a/gcc/testsuite/g++.dg/warn/pr86453.C b/gcc/testsuite/g++.dg/warn/pr86453.C new file mode 100644 index 00000000000..318f406b03d --- /dev/null +++ b/gcc/testsuite/g++.dg/warn/pr86453.C @@ -0,0 +1,5 @@ +// { dg-do compile } +// { dg-additional-options "-flto" { target lto } } +struct X { + int *__attribute__((aligned(2), packed)) a; // { dg-warning "attribute ignored" } +} b; -- 2.11.4.GIT