From bfd098e9011473417d2cec61c4b0d1dcd2da77b2 Mon Sep 17 00:00:00 2001 From: vries Date: Mon, 31 Aug 2015 09:12:15 +0000 Subject: [PATCH] Improve function header comments in tree-ssa-loop-manip.c 2015-08-31 Tom de Vries * tree-ssa-loop-manip.c (find_uses_to_rename_use) (find_uses_to_rename_stmt, find_uses_to_rename_bb, find_uses_to_rename): Improve function header comments. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@227334 138bc75d-0d04-0410-961f-82ee72b054a4 --- gcc/ChangeLog | 6 ++++++ gcc/tree-ssa-loop-manip.c | 24 ++++++++++++------------ 2 files changed, 18 insertions(+), 12 deletions(-) diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 16b61b2e1d2..a0123b12ad6 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,9 @@ +2015-08-31 Tom de Vries + + * tree-ssa-loop-manip.c (find_uses_to_rename_use) + (find_uses_to_rename_stmt, find_uses_to_rename_bb, find_uses_to_rename): + Improve function header comments. + 2015-08-30 Michael Collison PR other/67320 diff --git a/gcc/tree-ssa-loop-manip.c b/gcc/tree-ssa-loop-manip.c index cb762df4524..5c13d4b3731 100644 --- a/gcc/tree-ssa-loop-manip.c +++ b/gcc/tree-ssa-loop-manip.c @@ -366,7 +366,9 @@ get_loops_exits (bitmap *loop_exits) /* For USE in BB, if it is used outside of the loop it is defined in, mark it for rewrite. Record basic block BB where it is used - to USE_BLOCKS. Record the ssa name index to NEED_PHIS bitmap. */ + to USE_BLOCKS. Record the ssa name index to NEED_PHIS bitmap. + Note that for USEs in phis, BB should be the src of the edge corresponding to + the use, rather than the bb containing the phi. */ static void find_uses_to_rename_use (basic_block bb, tree use, bitmap *use_blocks, @@ -402,9 +404,8 @@ find_uses_to_rename_use (basic_block bb, tree use, bitmap *use_blocks, } /* For uses in STMT, mark names that are used outside of the loop they are - defined to rewrite. Record the set of blocks in that the ssa - names are defined to USE_BLOCKS and the ssa names themselves to - NEED_PHIS. */ + defined to rewrite. Record the set of blocks in which the ssa names are used + to USE_BLOCKS and the ssa names themselves to NEED_PHIS. */ static void find_uses_to_rename_stmt (gimple stmt, bitmap *use_blocks, bitmap need_phis) @@ -420,10 +421,9 @@ find_uses_to_rename_stmt (gimple stmt, bitmap *use_blocks, bitmap need_phis) find_uses_to_rename_use (bb, var, use_blocks, need_phis); } -/* Marks names that are used in BB and outside of the loop they are - defined in for rewrite. Records the set of blocks in that the ssa - names are defined to USE_BLOCKS. Record the SSA names that will - need exit PHIs in NEED_PHIS. */ +/* Marks names that are used in BB and outside of the loop they are defined in + for rewrite. Records the set of blocks in which the ssa names are used to + USE_BLOCKS. Record the SSA names that will need exit PHIs in NEED_PHIS. */ static void find_uses_to_rename_bb (basic_block bb, bitmap *use_blocks, bitmap need_phis) @@ -446,10 +446,10 @@ find_uses_to_rename_bb (basic_block bb, bitmap *use_blocks, bitmap need_phis) find_uses_to_rename_stmt (gsi_stmt (bsi), use_blocks, need_phis); } -/* Marks names that are used outside of the loop they are defined in - for rewrite. Records the set of blocks in that the ssa - names are defined to USE_BLOCKS. If CHANGED_BBS is not NULL, - scan only blocks in this set. */ +/* Marks names that are used outside of the loop they are defined in for + rewrite. Records the set of blocks in which the ssa names are used to + USE_BLOCKS. Record the SSA names that will need exit PHIs in NEED_PHIS. If + CHANGED_BBS is not NULL, scan only blocks in this set. */ static void find_uses_to_rename (bitmap changed_bbs, bitmap *use_blocks, bitmap need_phis) -- 2.11.4.GIT