From be9af3f79a5685098e16be9318d266bd65e855cf Mon Sep 17 00:00:00 2001 From: Sebastian Schuberth Date: Fri, 8 Mar 2013 20:45:06 +0100 Subject: [PATCH] Installer: Fix association of .sh files due to a GUID typo We also need to remove the "createvalueifdoesntexist" flag so that the fixed GUID is written to the Registry in case of an update installation. This issue was reported on the mailing list at https://groups.google.com/d/msg/msysgit/dd1qftVKGME/UdQtb3p1dfwJ Signed-off-by: Sebastian Schuberth --- share/WinGit/install.iss | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/share/WinGit/install.iss b/share/WinGit/install.iss index 77e7587c..ef03708e 100644 --- a/share/WinGit/install.iss +++ b/share/WinGit/install.iss @@ -13,7 +13,7 @@ #define COMP_CONSOLE_FONT 'Use a TrueType font in all console windows (not only for Git Bash)' -#define DROP_HANDLER_GUID '{{86C86720-42A0-1069-A2E8-08002B30309D}}' +#define DROP_HANDLER_GUID '{{86C86720-42A0-1069-A2E8-08002B30309D}' [Setup] ; Compiler-related @@ -138,7 +138,7 @@ Root: HKLM; Subkey: Software\Classes\sh_auto_file; ValueType: string; ValueData: Root: HKLM; Subkey: Software\Classes\sh_auto_file\shell\open\command; ValueType: string; ValueData: "{syswow64}\cmd.exe /C """"{app}\bin\sh.exe"" ""--login"" ""%1"" %*"""; Flags: createvalueifdoesntexist uninsdeletekeyifempty uninsdeletevalue; Check: IsAdminLoggedOn; Components: assoc_sh; OnlyBelowVersion: 6.0 Root: HKLM; Subkey: Software\Classes\sh_auto_file\shell\open\command; ValueType: string; ValueData: """{app}\bin\sh.exe"" ""--login"" ""%1"" %*"; Flags: createvalueifdoesntexist uninsdeletekeyifempty uninsdeletevalue; Check: IsAdminLoggedOn; Components: assoc_sh; MinVersion: 6.0 Root: HKLM; Subkey: Software\Classes\sh_auto_file\DefaultIcon; ValueType: string; ValueData: "%SystemRoot%\System32\shell32.dll,-153"; Flags: createvalueifdoesntexist uninsdeletekeyifempty uninsdeletevalue; Check: IsAdminLoggedOn; Components: assoc_sh -Root: HKLM; Subkey: Software\Classes\sh_auto_file\ShellEx\DropHandler; ValueType: string; ValueData: {#DROP_HANDLER_GUID}; Flags: createvalueifdoesntexist uninsdeletekeyifempty uninsdeletevalue; Check: IsAdminLoggedOn; Components: assoc_sh +Root: HKLM; Subkey: Software\Classes\sh_auto_file\ShellEx\DropHandler; ValueType: string; ValueData: {#DROP_HANDLER_GUID}; Flags: uninsdeletekeyifempty uninsdeletevalue; Check: IsAdminLoggedOn; Components: assoc_sh ; Install under HKEY_CURRENT_USER if a non-administrator is installing. Root: HKCU; Subkey: Software\Classes\.sh; ValueType: string; ValueData: sh_auto_file; Flags: createvalueifdoesntexist uninsdeletekeyifempty uninsdeletevalue; Check: not IsAdminLoggedOn; Components: assoc_sh @@ -146,7 +146,7 @@ Root: HKCU; Subkey: Software\Classes\sh_auto_file; ValueType: string; ValueData: Root: HKCU; Subkey: Software\Classes\sh_auto_file\shell\open\command; ValueType: string; ValueData: "{syswow64}\cmd.exe /C """"{app}\bin\sh.exe"" ""--login"" ""%1"" %*"""; Flags: createvalueifdoesntexist uninsdeletekeyifempty uninsdeletevalue; Check: not IsAdminLoggedOn; Components: assoc_sh; OnlyBelowVersion: 6.0 Root: HKCU; Subkey: Software\Classes\sh_auto_file\shell\open\command; ValueType: string; ValueData: """{app}\bin\sh.exe"" ""--login"" ""%1"" %*"; Flags: createvalueifdoesntexist uninsdeletekeyifempty uninsdeletevalue; Check: not IsAdminLoggedOn; Components: assoc_sh; MinVersion: 6.0 Root: HKCU; Subkey: Software\Classes\sh_auto_file\DefaultIcon; ValueType: string; ValueData: "%SystemRoot%\System32\shell32.dll,-153"; Flags: createvalueifdoesntexist uninsdeletekeyifempty uninsdeletevalue; Check: not IsAdminLoggedOn; Components: assoc_sh -Root: HKCU; Subkey: Software\Classes\sh_auto_file\ShellEx\DropHandler; ValueType: string; ValueData: {#DROP_HANDLER_GUID}; Flags: createvalueifdoesntexist uninsdeletekeyifempty uninsdeletevalue; Check: not IsAdminLoggedOn; Components: assoc_sh +Root: HKCU; Subkey: Software\Classes\sh_auto_file\ShellEx\DropHandler; ValueType: string; ValueData: {#DROP_HANDLER_GUID}; Flags: uninsdeletekeyifempty uninsdeletevalue; Check: not IsAdminLoggedOn; Components: assoc_sh [UninstallDelete] ; Delete the built-ins. -- 2.11.4.GIT