MDL-76052 webservice_xmlrpc: Remove it completely from core
commitdf227f38199fafbe25621b92cb6da856f9389d4b
authorEloy Lafuente (stronk7) <stronk7@moodle.org>
Fri, 21 Oct 2022 17:30:07 +0000 (21 19:30 +0200)
committerEloy Lafuente (stronk7) <stronk7@moodle.org>
Fri, 4 Nov 2022 15:49:52 +0000 (4 16:49 +0100)
tree79160e1eec7c6adbf00120d472c22396c6a2017e
parentfee1b8ce5fb829c7dc07c415796eb64e762258ba
MDL-76052 webservice_xmlrpc: Remove it completely from core

Normal removal procedure:
  - Remove the plugin completely from core.
  - Document it in the webservices upgrade.txt file.
  - Add a core upgrade step to proceed to remove any configuration
    if the plugin has not been re-installed manually.

Plus:
  - Remove a few remaining uses in the hub/sites registration scripts,
    that were moved from xmlrpc to hand.made rest calls by MDL-31436
    (Moodle 3.4.1 and up) and never removed then.
  - Remove the php-xmlrpc extension as a recommendation in composer.
  - Remove "xmlrpc" from various comments, trivial cleanup.

Note:
  - While working on this MDL-76078 has been created about to
    fix a serious design problem detected (it does not affect
    functionality). That's out from this issue scope.
22 files changed:
composer.json
lib/classes/hub/api.php
lib/classes/plugin_manager.php
lib/classes/plugininfo/webservice.php
lib/db/upgrade.php
version.php
webservice/lib.php
webservice/upgrade.txt
webservice/xmlrpc/classes/privacy/provider.php [deleted file]
webservice/xmlrpc/db/access.php [deleted file]
webservice/xmlrpc/lang/en/webservice_xmlrpc.php [deleted file]
webservice/xmlrpc/lib.php [deleted file]
webservice/xmlrpc/locallib.php [deleted file]
webservice/xmlrpc/server.php [deleted file]
webservice/xmlrpc/simpleserver.php [deleted file]
webservice/xmlrpc/tests/fixtures/array_response.xml [deleted file]
webservice/xmlrpc/tests/fixtures/fault_response.xml [deleted file]
webservice/xmlrpc/tests/fixtures/value_response.xml [deleted file]
webservice/xmlrpc/tests/lib_test.php [deleted file]
webservice/xmlrpc/tests/locallib_test.php [deleted file]
webservice/xmlrpc/tests/xmlrpc_server_test.php [deleted file]
webservice/xmlrpc/version.php [deleted file]