MDL-75111 phpunit: Move tests to use correct names and ns (take#4)
commit83b490a5947642a3f6e73520402bb5e63edf8022
authorEloy Lafuente (stronk7) <stronk7@moodle.org>
Fri, 1 Jul 2022 14:43:34 +0000 (1 16:43 +0200)
committerEloy Lafuente (stronk7) <stronk7@moodle.org>
Fri, 26 Aug 2022 14:34:20 +0000 (26 16:34 +0200)
treedba5fee76ae07f8af361776354f5bab58d19ab15
parent952d9e9f188370bb33f29f54d4682c9eca87b872
MDL-75111 phpunit: Move tests to use correct names and ns (take#4)

Applied the following changes to various testcase classes:

- Namespaced with component[\level2-API]
- Moved to level2-API subdirectory when required.
- Fixed incorrect use statements with leading backslash.
- Remove file phpdoc block
- Remove MOODLE_INTERNAL if not needed.
- Changed code to point to global scope when needed.
- Fix some relative paths and comments here and there.
- All them passing individually.
- Complete runs passing too.

Special mention to:

- The following task tests have been moved within the level2 directory:
  - \core\adhoc_task_test => \core\task\adhoc_task_test
  - \core\scheduled_task_test => \core\task\scheduled_task_test
  - \core\calendar_cron_task_test => \core\task\calendar_cron_task_test
  - \core\h5p_get_content_types_task_test => \core\task\h5p_get_content_types_task_test
  - \core\task_database_logger_test => \core\task\database_logger_test
  - \core\task_logging_test => \core\task\logging_test

- The following event tests have been moved within level2 directory:
  - \core\event_context_locked_test => \core\event\context_locked_test
  - \core\event_deprecated_test => \core\event\deprecated_test
  - \core\event_grade_deleted_test => \core\event\grade_deleted_test
  - \core\event_profile_field_test => \core\event\profile_field_test
  - \core\event_unknown_logged_test => \core\event\unknown_logged_test
  - \core\event_user_graded_test => \core\event\user_graded_test
  - \core\event_user_password_updated_test => \core\event\user_password_updated_test

- The following output tests have been moved within level2 directory:
  - \core\mustache_template_finder_test => \core\output\mustache_template_finder_test
  - \core\mustache_template_source_loader_test => \core\output\mustache_template_source_loader_test
  - \core\output_mustache_helper_collection_test => \core\output\mustache_helper_collection_test

- The following tests have been moved to their correct tests directories:
  - lib/tests/time_splittings_test.php => analytics/tests/time_splittings_test.php

- All the classes and tests under lib/filebrowser and lib/filestorage
  belong to core, not to core_files. Some day we should move
  them to their correct subsystem.
- All the classes and tests under lib/grade belong to core, not
  to core_grades. Some day we should move them to their correct
  subsystem.
- The core_grades_external class and its \core\grades_external_test
  unit test should belong to the grades subsystem or, alternatively,
  to \core\external, they both should be moved together.
- The core_grading_external class and its \core\grading_external_test
  unit test should belong to the grading subsystem or, alternatively,
  to \core\external, they both should be moved together.
- The \core\message\message and \core\message\inbound (may be others)
  classes, and their associated tests should go to the core_message
  subsystem.
- The core_user class, and its associated tests should go to the
  core_user subsystem.
- The \core\update namespace is plain wrong (update is not valid API)
  and needs action 1) create it or 2) move elsewhere.
125 files changed:
analytics/tests/analysis_test.php
analytics/tests/calculation_info_test.php
analytics/tests/dataset_manager_test.php
analytics/tests/indicator_test.php
analytics/tests/model_test.php
analytics/tests/prediction_actions_test.php
analytics/tests/prediction_test.php
analytics/tests/stats_test.php
analytics/tests/time_splittings_test.php [moved from lib/tests/time_splittings_test.php with 95% similarity]
lib/ddl/tests/ddl_test.php
lib/dml/tests/dml_table_test.php
lib/dml/tests/dml_test.php
lib/dml/tests/recordset_walk_test.php
lib/dml/tests/sqlsrv_native_moodle_database_test.php
lib/editor/tinymce/tests/editor_test.php
lib/filebrowser/tests/file_browser_test.php
lib/filestorage/tests/file_storage_test.php
lib/filestorage/tests/file_system_filedir_test.php
lib/filestorage/tests/file_system_test.php
lib/filestorage/tests/mbz_packer_test.php
lib/filestorage/tests/tgz_packer_test.php
lib/filestorage/tests/zip_packer_test.php
lib/form/tests/autocomplete_test.php
lib/form/tests/dateselector_test.php
lib/form/tests/datetimeselector_test.php
lib/form/tests/duration_test.php
lib/form/tests/float_test.php
lib/grade/tests/grade_category_test.php
lib/grade/tests/grade_grade_test.php
lib/grade/tests/grade_item_test.php
lib/grade/tests/grade_object_test.php
lib/grade/tests/grade_outcome_test.php
lib/grade/tests/grade_scale_test.php
lib/phpunit/tests/advanced_test.php
lib/phpunit/tests/basic_test.php
lib/phpunit/tests/util_test.php
lib/tests/adminlib_test.php
lib/tests/admintree_test.php
lib/tests/ajaxlib_test.php
lib/tests/analysers_test.php
lib/tests/authlib_test.php
lib/tests/check_test.php
lib/tests/collator_test.php
lib/tests/componentlib_test.php
lib/tests/configonlylib_test.php
lib/tests/core_media_player_native_test.php
lib/tests/core_renderer_template_exploit_test.php
lib/tests/cronlib_test.php
lib/tests/csslib_test.php
lib/tests/csvclass_test.php
lib/tests/curl_security_helper_test.php
lib/tests/customcontext_test.php
lib/tests/datalib_update_with_unique_index_test.php
lib/tests/date_legacy_test.php
lib/tests/editorlib_test.php
lib/tests/environment_test.php
lib/tests/event/context_locked_test.php [moved from lib/tests/event_context_locked_test.php with 85% similarity]
lib/tests/event/deprecated_test.php [moved from lib/tests/event_deprecated_test.php with 77% similarity]
lib/tests/event/grade_deleted_test.php [moved from lib/tests/event_grade_deleted_test.php with 80% similarity]
lib/tests/event/profile_field_test.php [moved from lib/tests/event_profile_field_test.php with 97% similarity]
lib/tests/event/unknown_logged_test.php [moved from lib/tests/event_unknown_logged_test.php with 88% similarity]
lib/tests/event/user_graded_test.php [moved from lib/tests/event_user_graded_test.php with 84% similarity]
lib/tests/event/user_password_updated_test.php [moved from lib/tests/event_user_password_updated_test.php with 85% similarity]
lib/tests/exporter_test.php
lib/tests/filelib_test.php
lib/tests/filestorage_zip_archive_test.php
lib/tests/filetypes_test.php
lib/tests/filter_manager_test.php
lib/tests/filterlib_test.php
lib/tests/formslib_test.php
lib/tests/gdlib_test.php
lib/tests/googlelib_test.php
lib/tests/gradelib_test.php
lib/tests/grades_external_test.php [moved from lib/tests/grades_externallib_test.php with 90% similarity]
lib/tests/grading_external_test.php [moved from lib/tests/grading_externallib_test.php with 96% similarity]
lib/tests/grouplib_test.php
lib/tests/html2text_test.php
lib/tests/htmlpurifier_test.php
lib/tests/ip_utils_test.php
lib/tests/jquery_test.php
lib/tests/ldaplib_test.php
lib/tests/lock_config_test.php
lib/tests/lock_test.php
lib/tests/markdown_test.php
lib/tests/mathslib_test.php
lib/tests/medialib_test.php
lib/tests/message_test.php
lib/tests/messageinbound_test.php
lib/tests/minify_test.php
lib/tests/moodle_page_test.php
lib/tests/moodle_url_test.php
lib/tests/myprofilelib_test.php
lib/tests/navigationlib_test.php
lib/tests/notification_test.php
lib/tests/output/mustache_helper_collection_test.php [moved from lib/tests/output_mustache_helper_collection_test.php with 97% similarity]
lib/tests/output/mustache_template_finder_test.php [moved from lib/tests/mustache_template_finder_test.php with 95% similarity]
lib/tests/output/mustache_template_source_loader_test.php [moved from lib/tests/mustache_template_source_loader_test.php with 97% similarity]
lib/tests/outputcomponents_test.php
lib/tests/outputfactories_test.php
lib/tests/outputrequirementslib_test.php
lib/tests/pdflib_test.php
lib/tests/plugin_manager_test.php
lib/tests/qrcode_test.php
lib/tests/regex_test.php
lib/tests/requirejs_test.php
lib/tests/session_manager_test.php
lib/tests/session_redis_test.php
lib/tests/sessionlib_test.php
lib/tests/setuplib_test.php
lib/tests/statslib_test.php
lib/tests/string_manager_standard_test.php
lib/tests/tablelib_test.php
lib/tests/task/adhoc_task_test.php [moved from lib/tests/adhoc_task_test.php with 63% similarity]
lib/tests/task/calendar_cron_task_test.php [moved from lib/tests/calendar_cron_task_test.php with 83% similarity]
lib/tests/task/database_logger_test.php [moved from lib/tests/task_database_logger_test.php with 97% similarity]
lib/tests/task/h5p_get_content_types_task_test.php [moved from lib/tests/h5p_get_content_types_task_test.php with 87% similarity]
lib/tests/task/logging_test.php [moved from lib/tests/task_logging_test.php with 80% similarity]
lib/tests/task/scheduled_task_test.php [moved from lib/tests/scheduled_task_test.php with 83% similarity]
lib/tests/update_api_test.php
lib/tests/update_checker_test.php
lib/tests/update_code_manager_test.php
lib/tests/update_validator_test.php
lib/tests/upgrade_util_test.php
lib/tests/user_menu_test.php
lib/tests/user_test.php