MDL-75952 general: Since php81, refection->setAccessible() is no-op361dfe814542e460c4d2da06bd41561403d10b87
commit361dfe814542e460c4d2da06bd41561403d10b87
authorEloy Lafuente (stronk7) <stronk7@moodle.org>
Sun, 10 Mar 2024 17:11:25 +0000 (10 18:11 +0100)
committerEloy Lafuente (stronk7) <stronk7@moodle.org>
Sun, 10 Mar 2024 20:15:00 +0000 (10 21:15 +0100)
tree452bbcde2c1fea080cfd329197bf639fe02c5581
parent38a3310c9272edfbac77ee4a8527e7838642072e
MDL-75952 general: Since php81, refection->setAccessible() is no-op

Refereces:
- https://wiki.php.net/rfc/make-reflection-setaccessible-no-op
- https://www.php.net/manual/en/reflectionproperty.setaccessible.php
- https://www.php.net/manual/en/reflectionmethod.setaccessible.php

As of PHP 8.1.0, calling this method has no effect; all methods are
invokable by default. So, let's remove all uses from core, they are
no-op.
134 files changed:
admin/presets/tests/generator/lib.php
admin/tool/dataprivacy/tests/expired_contexts_test.php
admin/tool/dataprivacy/tests/filtered_userlist_test.php
admin/tool/langimport/tests/locale_test.php
admin/tool/licensemanager/tests/manager_test.php
admin/tool/mfa/factor/email/tests/factor_test.php
admin/tool/mfa/factor/sms/tests/factor_test.php
admin/tool/mfa/factor/token/tests/factor_test.php
admin/tool/mfa/tests/secret_manager_test.php
admin/tool/usertours/tests/manager_test.php
admin/tool/usertours/tests/step_test.php
admin/tool/usertours/tests/tour_test.php
analytics/tests/community_of_inquiry_activities_completed_by.php
analytics/tests/model_test.php
backup/moodle2/tests/backup_stepslib_test.php
backup/moodle2/tests/restore_gradebook_structure_step_test.php
backup/tests/automated_backup_test.php
backup/util/dbops/tests/restore_dbops_test.php
backup/util/helper/tests/restore_log_rule_test.php
badges/tests/badgeslib_test.php
badges/tests/output/manage_badge_action_bar_test.php
blocks/accessreview/tests/accessibility_review_test.php
blog/tests/lib_test.php
cache/stores/redis/lib.php
cache/tests/cache_test.php
calendar/tests/calendar_event_exporter_test.php
calendar/tests/rrule_manager_test.php
communication/provider/matrix/tests/local/command_test.php
communication/provider/matrix/tests/matrix_client_test.php
contentbank/tests/contentbank_test.php
course/format/tests/local/baseactions_test.php
course/tests/category_hooks_test.php
course/tests/course_image_cache_test.php
course/tests/targets_test.php
customfield/tests/generator/lib.php
enrol/ldap/tests/ldap_test.php
enrol/lti/tests/helper_test.php
files/tests/converter_test.php
grade/report/user/tests/lib_test.php
h5p/tests/editor_test.php
h5p/tests/file_storage_test.php
h5p/tests/generator/lib.php
lib/behat/classes/named_selector.php
lib/classes/scss.php
lib/ddl/tests/ddl_test.php
lib/dml/tests/dml_mysqli_read_slave_test.php
lib/dml/tests/dml_test.php
lib/dml/tests/fixtures/test_dml_sql_debugging_fixture.php
lib/dml/tests/fixtures/test_moodle_read_slave_trait.php
lib/dml/tests/mysqli_native_moodle_database_test.php
lib/dml/tests/pgsql_native_moodle_database_test.php
lib/dml/tests/sqlsrv_native_moodle_database_test.php
lib/external/tests/external_api_test.php
lib/filestorage/tests/file_system_filedir_test.php
lib/filestorage/tests/file_system_test.php
lib/phpunit/classes/util.php
lib/phpunit/tests/phpunit_dataset_test.php
lib/tests/accesslib_test.php
lib/tests/analysers_test.php
lib/tests/client_test.php
lib/tests/completionlib_test.php
lib/tests/component_test.php
lib/tests/core_renderer_template_exploit_test.php
lib/tests/external/check/get_result_admintree_test.php
lib/tests/filelib_test.php
lib/tests/filestorage_zip_archive_test.php
lib/tests/http_client_test.php
lib/tests/medialib_test.php
lib/tests/moodlenet/activity_packager_test.php
lib/tests/moodlenet/activity_sender_test.php
lib/tests/moodlenet/course_packager_test.php
lib/tests/moodlenet/course_partial_packager_test.php
lib/tests/moodlenet/course_partial_sender_test.php
lib/tests/moodlenet/course_sender_test.php
lib/tests/myprofilelib_test.php
lib/tests/navigation/output/primary_test.php
lib/tests/navigation/views/primary_test.php
lib/tests/navigation/views/secondary_test.php
lib/tests/output/language_menu_test.php
lib/tests/output/participants_action_bar_test.php
lib/tests/outputrequirementslib_test.php
lib/tests/session_manager_test.php
lib/tests/session_redis_test.php
lib/tests/setuplib_test.php
lib/tests/xhprof_test.php
mod/assign/feedback/editpdf/tests/document_services_test.php
mod/assign/tests/downloader_test.php
mod/assign/tests/locallib_participants_test.php
mod/assign/tests/locallib_test.php
mod/bigbluebuttonbn/classes/test/subplugins_test_helper_trait.php
mod/bigbluebuttonbn/tests/behat/behat_mod_bigbluebuttonbn.php
mod/bigbluebuttonbn/tests/instance_test.php
mod/bigbluebuttonbn/tests/lib_test.php
mod/bigbluebuttonbn/tests/local/extension_test.php
mod/bigbluebuttonbn/tests/local/proxy/proxy_base_test.php
mod/bigbluebuttonbn/tests/task/base_send_notification_test.php
mod/data/lib.php
mod/data/tests/preset_test.php
mod/feedback/tests/item_test.php
mod/forum/tests/lib_test.php
mod/h5pactivity/tests/output/result/result_test.php
mod/h5pactivity/tests/xapi/handler_test.php
mod/quiz/accessrule/seb/tests/access_manager_test.php
mod/quiz/accessrule/seb/tests/rule_test.php
mod/quiz/classes/adminpresets/adminpresets_review_setting.php
mod/quiz/report/overview/tests/report_test.php
mod/quiz/report/statistics/tests/quiz_statistics_report_test.php
mod/quiz/report/statistics/tests/statistics_table_test.php
mod/quiz/tests/local_structure_slot_random_test.php
mod/workshop/allocation/scheduled/tests/scheduled_allocator_test.php
mod/workshop/tests/locallib_test.php
mod/workshop/tests/portfolio_caller_test.php
notes/tests/lib_test.php
privacy/tests/contextlist_test.php
privacy/tests/moodle_content_writer_test.php
question/bank/statistics/tests/helper_test.php
question/engine/tests/datalib_test.php
question/engine/tests/question_engine_test.php
question/tests/local/statistics/statistics_bulk_loader_test.php
question/tests/version_test.php
question/type/ddwtos/tests/form/edit_form_test.php
question/type/gapselect/tests/form/edit_form_test.php
question/type/numerical/tests/answerprocessor_test.php
report/log/tests/lib_test.php
report/outline/tests/lib_test.php
report/stats/tests/lib_test.php
report/usersessions/tests/lib_test.php
reportbuilder/tests/datasource_test.php
reportbuilder/tests/local/report/base_test.php
repository/dropbox/tests/api_test.php
repository/nextcloud/tests/access_controlled_link_manager_test.php
repository/nextcloud/tests/lib_test.php
theme/boost/tests/boostnavbar_test.php
webservice/rest/tests/server_test.php