| commit | c6a8c0e38afab1ef175598d3533c237e4fcca847 | |
| author | Rolf Bjarne Kvinge <rolf@xamarin.com> | |
| Wed, 11 Apr 2018 13:35:22 +0000 (11 15:35 +0200) | ||
| committer | Marek Safar <marek.safar@gmail.com> | |
| Fri, 13 Apr 2018 12:26:58 +0000 (13 14:26 +0200) | ||
| tree | e7577c85f56f5b851c4eae4c41af1a99bcad6c4d | treesnapshot (tar.gz zip) |
| parent | c2e1021ed00ba915255ba78f23758c50982a1713 | commitdiff |
[System.Net.Http] Use '*' as the host instead of '+' in the tests. Fixes xamarin/maccore#673.
Use '*' as the host instead of '+' in the tests.
The behavior should be the same, just faster, because '+' will fail to resolve
("Could not resolve host '+'"), and we'll fall back to the same behavior as
'*': https://github.com/mono/mono/blob/5128cce2dcd097aa4e7b86dd3b56e833c15a9ff0/mcs/class/System/System.Net/EndPointManager.cs#L83-L96
The problem arises when failing to resolve '+' takes a long time: on some of
our bots it takes 5-10 seconds. This adds up quickly since the tests try many
times, effectively increasing a test run from 1-2 seconds to 30+ minutes.
Fixes https://github.com/xamarin/maccore/issues/673.
Use '*' as the host instead of '+' in the tests.
The behavior should be the same, just faster, because '+' will fail to resolve
("Could not resolve host '+'"), and we'll fall back to the same behavior as
'*': https://github.com/mono/mono/blob/5128cce2dcd097aa4e7b86dd3b56e833c15a9ff0/mcs/class/System/System.Net/EndPointManager.cs#L83-L96
The problem arises when failing to resolve '+' takes a long time: on some of
our bots it takes 5-10 seconds. This adds up quickly since the tests try many
times, effectively increasing a test run from 1-2 seconds to 30+ minutes.
Fixes https://github.com/xamarin/maccore/issues/673.
| mcs/class/System.Net.Http/Test/System.Net.Http/HttpClientTest.cs | diffblobblamehistory |