| commit | 6d58de2533ddace90b47f95a95b24dd3c22ce01c | |
| author | Linus Torvalds <torvalds@linux-foundation.org> | |
| Fri, 25 Sep 2009 20:12:47 +0000 (25 22:12 +0200) | ||
| committer | james toy <toyj@union.edu> | |
| Fri, 25 Sep 2009 20:12:47 +0000 (25 22:12 +0200) | ||
| tree | 484fae7583c6ef507148cf632ded3808d891fab7 | treesnapshot (tar.gz zip) |
| parent | 278288739756144a603fd38f3d20482ca72fc252 | commitdiff |
The all-ones value is not just a "device didn't exist" case, it's also
potentially a quite valid value, so not restoring it would be wrong.
What *would* be interesting is to hear where the bad values came from in
the first place. It sounds like the device state is saved after the PCI
bus controller in front of the device has been crapped on, resulting in the
PCI config cycles never reaching the device at all.
Something along this patch (together with suspend/resume debugging output)
migth help pinpoint it. But it really sounds like something totally
brokenly turned off the PCI bridge (some ACPI shutdown crud? I wouldn't be
entirely surprised)
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
potentially a quite valid value, so not restoring it would be wrong.
What *would* be interesting is to hear where the bad values came from in
the first place. It sounds like the device state is saved after the PCI
bus controller in front of the device has been crapped on, resulting in the
PCI config cycles never reaching the device at all.
Something along this patch (together with suspend/resume debugging output)
migth help pinpoint it. But it really sounds like something totally
brokenly turned off the PCI bridge (some ACPI shutdown crud? I wouldn't be
entirely surprised)
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
| drivers/pci/pci.c | diffblobblamehistory |