| commit | cf95a4b52defc0daf910a71f76e5f647eb28bd1d | |
| author | Julia Lawall <julia@diku.dk> | |
| Sun, 13 Dec 2009 05:47:04 +0000 (13 05:47 +0000) | ||
| committer | Greg Kroah-Hartman <gregkh@suse.de> | |
| Wed, 6 Jan 2010 22:26:25 +0000 (6 14:26 -0800) | ||
| tree | 0c3e83ebd9d3f2d776823fd6bfb60fbae757f3e5 | treesnapshot (tar.gz zip) |
| parent | 2ebcfd6c0ef863636ce215f71c70c3b2d4e57a6f | commitdiff |
drivers/net/usb: Correct code taking the size of a pointer
commit 6057912d7baad31be9819518674ffad349a065b1 upstream.
sizeof(dev->dev_addr) is the size of a pointer. A few lines above, the
size of this field is obtained using netdev->addr_len for a call to memcpy,
so do the same here.
A simplified version of the semantic patch that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@@
expression *x;
expression f;
type T;
@@
*f(...,(T)x,...)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
commit 6057912d7baad31be9819518674ffad349a065b1 upstream.
sizeof(dev->dev_addr) is the size of a pointer. A few lines above, the
size of this field is obtained using netdev->addr_len for a call to memcpy,
so do the same here.
A simplified version of the semantic patch that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@@
expression *x;
expression f;
type T;
@@
*f(...,(T)x,...)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| drivers/net/usb/rtl8150.c | diffblobblamehistory |