| commit | 85a2f9b46f8cd8aaa11c64c715e1ea3ec27ec486 | |
| author | Steven Rostedt <srostedt@redhat.com> | |
| Fri, 27 Feb 2009 05:12:38 +0000 (27 00:12 -0500) | ||
| committer | Steven Rostedt <srostedt@redhat.com> | |
| Fri, 27 Feb 2009 05:12:38 +0000 (27 00:12 -0500) | ||
| tree | 76079c21b3bb5763c19eb617f9e29139789cc903 | treesnapshot (tar.gz zip) |
| parent | d8e83d26b5ab3b31ee0ff6d093a2627707a1e221 | commitdiff |
tracing: use pointer error returns for __tracing_open
Impact: fix compile warning and clean up
When I first wrote __tracing_open, instead of passing the error
code via the ERR_PTR macros, I lazily used a separate parameter
to hold the return for errors.
When Frederic Weisbecker updated that function, he used the Linux
kernel ERR_PTR for the returns. This caused the parameter return
to possibly not be initialized on error. gcc correctly pointed this
out with a warning.
This patch converts the entire function to use the Linux kernel
ERR_PTR macro methods.
Signed-off-by: Steven Rostedt <srostedt@redhat.com>
Impact: fix compile warning and clean up
When I first wrote __tracing_open, instead of passing the error
code via the ERR_PTR macros, I lazily used a separate parameter
to hold the return for errors.
When Frederic Weisbecker updated that function, he used the Linux
kernel ERR_PTR for the returns. This caused the parameter return
to possibly not be initialized on error. gcc correctly pointed this
out with a warning.
This patch converts the entire function to use the Linux kernel
ERR_PTR macro methods.
Signed-off-by: Steven Rostedt <srostedt@redhat.com>
| kernel/trace/trace.c | diffblobblamehistory |