| commit | 76266b2ad38c33fb2c1475cfeb35ed070adaba2b | |
| author | Lennert Buytenhek <buytenh@wantstofly.org> | |
| Thu, 16 Jul 2009 09:07:09 +0000 (16 11:07 +0200) | ||
| committer | John W. Linville <linville@tuxdriver.com> | |
| Thu, 20 Aug 2009 15:38:06 +0000 (20 11:38 -0400) | ||
| tree | 6e0abe8fbfd68d8627099358b300c830c99eb42e | treesnapshot (tar.gz zip) |
| parent | 240e86efd60e6bc232a072273a7f7794bcb035e0 | commitdiff |
mwl8k: dma header manipulations can't fail
Adding and removing the DMA header that the mwl8k hardware requires
on tx and provides on rx can never fail, since we are guaranteed to
have enough headroom on the tx path to expand the packet, and we only
ever shrink the packet on the rx path. (And on both paths we are
guaranteed to be the only user of the skb we are handling.)
This allows removing all of the skb clone handling in the tx and tx
reclaim paths, and eliminates error checks in both the tx and rx
paths, simplifying the code a bit more.
Signed-off-by: Lennert Buytenhek <buytenh@marvell.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Adding and removing the DMA header that the mwl8k hardware requires
on tx and provides on rx can never fail, since we are guaranteed to
have enough headroom on the tx path to expand the packet, and we only
ever shrink the packet on the rx path. (And on both paths we are
guaranteed to be the only user of the skb we are handling.)
This allows removing all of the skb clone handling in the tx and tx
reclaim paths, and eliminates error checks in both the tx and rx
paths, simplifying the code a bit more.
Signed-off-by: Lennert Buytenhek <buytenh@marvell.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
| drivers/net/wireless/mwl8k.c | diffblobblamehistory |